media: stv0367: prevent division by zero
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Sun, 25 Jun 2017 12:07:45 +0000 (09:07 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sun, 25 Jun 2017 12:07:45 +0000 (09:07 -0300)
While there's a test at the SNR calculus to avoid division by
zero, it will still follow the path that would do the division.
So, add a missing break there.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/dvb-frontends/stv0367.c

index fee2a15542033c1027040279bc50b7159dbb879e..e7bed20e80f6b3202380e4e1188335ede098d9e0 100644 (file)
@@ -3014,8 +3014,10 @@ static void stv0367ddb_read_snr(struct dvb_frontend *fe)
                regval = stv0367cab_snr_readreg(fe, 0);
 
                /* prevent division by zero */
-               if (!regval)
+               if (!regval) {
                        snrval = 0;
+                       break;
+               }
 
                tmpval = (cab_pwr * 320) / regval;
                snrval = ((tmpval != 0) ? (intlog2(tmpval) / 5581) : 0);