cxl/security: Fix Get Security State output payload endian handling

Multi-byte integer values in CXL mailbox payloads are little endian. Add
a definition of the Get Security State output payload and convert the
value before testing flags.

Fixes: 328281155539 ("cxl/pmem: Introduce nvdimm_security_ops with ->get_flags() operation")
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Link: https://lore.kernel.org/r/167030054822.4044561.4917796262037689553.stgit@dwillia2-xfh.jf.intel.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>

diff --git a/drivers/cxl/security.c b/drivers/cxl/security.c
index 5484d4eecfd1a1afd26b3fa7b12238f1291a09a8..ebb78b8944f5751b2402fe04043407a81a61df8e 100644 (file)
--- a/drivers/cxl/security.c
+++ b/drivers/cxl/security.c
@@ -16,14 +16,18 @@ static unsigned long cxl_pmem_get_security_flags(struct nvdimm *nvdimm,
        struct cxl_memdev *cxlmd = cxl_nvd->cxlmd;
        struct cxl_dev_state *cxlds = cxlmd->cxlds;
        unsigned long security_flags = 0;
+       struct cxl_get_security_output {
+               __le32 flags;
+       } out;
        u32 sec_out;
        int rc;
 
        rc = cxl_mbox_send_cmd(cxlds, CXL_MBOX_OP_GET_SECURITY_STATE, NULL, 0,
-                              &sec_out, sizeof(sec_out));
+                              &out, sizeof(out));
        if (rc < 0)
                return 0;
 
+       sec_out = le32_to_cpu(out.flags);
        if (ptype == NVDIMM_MASTER) {
                if (sec_out & CXL_PMEM_SEC_STATE_MASTER_PASS_SET)
                        set_bit(NVDIMM_SECURITY_UNLOCKED, &security_flags);