mediatek: mt76: mac80211: Fix missing of_node_put() in mt76_led_init()
authorLiang He <windhl@126.com>
Mon, 4 Jul 2022 08:34:20 +0000 (16:34 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:23:29 +0000 (14:23 +0200)
[ Upstream commit 0a14c1d0113f121151edf34333cdf212dd209190 ]

We should use of_node_put() for the reference 'np' returned by
of_get_child_by_name() which will increase the refcount.

Fixes: 17f1de56df05 ("mt76: add common code shared between multiple chipsets")
Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/mediatek/mt76/mac80211.c

index 029599d68ca7131d012209c5f3063f9958a5a206..028519a739fd1dcf7fd7ccf646e4050403abdea1 100644 (file)
@@ -123,6 +123,7 @@ static int mt76_led_init(struct mt76_dev *dev)
                if (!of_property_read_u32(np, "led-sources", &led_pin))
                        dev->led_pin = led_pin;
                dev->led_al = of_property_read_bool(np, "led-active-low");
+               of_node_put(np);
        }
 
        return led_classdev_register(dev->dev, &dev->led_cdev);