staging: lustre: statahead: remove incorrect test on agl_list_empty()
authorNeilBrown <neilb@suse.com>
Thu, 1 Mar 2018 23:31:25 +0000 (10:31 +1100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 6 Mar 2018 12:17:27 +0000 (04:17 -0800)
Including agl_list_empty() in the wait_event_idle() condition
is pointless as the body of the loop doesn't do anything
about the agl list.
So if the list wasn't empty, the while loop would spin
indefinitely.

The test was removed in the lustre-release commit
672ab0e00d61 ("LU-3270 statahead: small fixes and cleanup"),
but not in the Linux commit 5231f7651c55 ("staging: lustre:
statahead: small fixes and cleanup").

Fixes: 5231f7651c55 ("staging: lustre: statahead: small fixes and cleanup")
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/llite/statahead.c

index 6052bfd7ff0565bb69584c2c323cef8051f1112e..ba00881a5745dcdd3e58c64ecedfe48f1a9309f4 100644 (file)
@@ -1124,7 +1124,6 @@ static int ll_statahead_thread(void *arg)
        while (thread_is_running(sa_thread)) {
                wait_event_idle(sa_thread->t_ctl_waitq,
                                sa_has_callback(sai) ||
-                               !agl_list_empty(sai) ||
                                !thread_is_running(sa_thread));
 
                sa_handle_callback(sai);