tracing: Make unregister_trigger() static
authorSteven Rostedt (VMware) <rostedt@goodmis.org>
Tue, 24 Jul 2018 22:55:58 +0000 (18:55 -0400)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Thu, 26 Jul 2018 14:50:18 +0000 (10:50 -0400)
Nothing uses unregister_trigger() outside of trace_events_trigger.c file,
thus it should be static. Not sure why this was ever converted, because
its counter part, register_trigger(), was always static.

Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace.h
kernel/trace/trace_events_trigger.c

index f8f86231ad90e48b73b7eb2dc8d1def48071219a..3f9d9acc69e6ef23fb51ab4e778d8f0890f0ea8e 100644 (file)
@@ -1533,9 +1533,6 @@ extern int event_trigger_init(struct event_trigger_ops *ops,
 extern int trace_event_trigger_enable_disable(struct trace_event_file *file,
                                              int trigger_enable);
 extern void update_cond_flag(struct trace_event_file *file);
-extern void unregister_trigger(char *glob, struct event_trigger_ops *ops,
-                              struct event_trigger_data *test,
-                              struct trace_event_file *file);
 extern int set_trigger_filter(char *filter_str,
                              struct event_trigger_data *trigger_data,
                              struct trace_event_file *file);
index 5dea177cef53120129c7d4a4d76eacb67ad66db0..58d21fd5293206975764394a92bbaa757050876f 100644 (file)
@@ -579,9 +579,9 @@ out:
  * Usually used directly as the @unreg method in event command
  * implementations.
  */
-void unregister_trigger(char *glob, struct event_trigger_ops *ops,
-                       struct event_trigger_data *test,
-                       struct trace_event_file *file)
+static void unregister_trigger(char *glob, struct event_trigger_ops *ops,
+                              struct event_trigger_data *test,
+                              struct trace_event_file *file)
 {
        struct event_trigger_data *data;
        bool unregistered = false;