mmc: core: Log about empty non-removable slots
authorMarc Gonzalez <marc.w.gonzalez@free.fr>
Tue, 21 Mar 2023 18:01:01 +0000 (19:01 +0100)
committerUlf Hansson <ulf.hansson@linaro.org>
Fri, 24 Mar 2023 15:48:01 +0000 (16:48 +0100)
Failing to detect a non-removable card shouldn't happen. Let's log a
message about it to inform that we have problem that ought to be fixed.

Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
Link: https://lore.kernel.org/r/d2444591-c91b-a94d-71e2-9dedc3b6c514@free.fr
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/core/core.c

index 426c7f66b34924dc1bc2395522f25418f3813e66..3d3e0ca5261481a86069e38261678924524448b6 100644 (file)
@@ -2257,6 +2257,11 @@ void mmc_rescan(struct work_struct *work)
                        break;
        }
 
+       /* A non-removable card should have been detected by now. */
+       if (!mmc_card_is_removable(host) && !host->bus_ops)
+               pr_info("%s: Failed to initialize a non-removable card",
+                       mmc_hostname(host));
+
        /*
         * Ignore the command timeout errors observed during
         * the card init as those are excepted.