ASoC: Intel: atom: controls: remove useless initializations
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 20 May 2022 21:17:11 +0000 (16:17 -0500)
committerMark Brown <broonie@kernel.org>
Mon, 6 Jun 2022 11:35:14 +0000 (12:35 +0100)
cppcheck complains about invalid NULL dereferences but there's indeed
no need to initialize loop variables or before allocating memory.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20220520211719.607543-9-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/atom/sst-atom-controls.c

index 335c3273299455f4045a1b451274b53d776a9b85..34d63252debfd3b67482d964a11dcbb2fee5b792 100644 (file)
@@ -1328,7 +1328,7 @@ int sst_send_pipe_gains(struct snd_soc_dai *dai, int stream, int mute)
 {
        struct sst_data *drv = snd_soc_dai_get_drvdata(dai);
        struct snd_soc_dapm_widget *w;
-       struct snd_soc_dapm_path *p = NULL;
+       struct snd_soc_dapm_path *p;
 
        dev_dbg(dai->dev, "enter, dai-name=%s dir=%d\n", dai->name, stream);
 
@@ -1392,7 +1392,7 @@ int sst_send_pipe_gains(struct snd_soc_dai *dai, int stream, int mute)
 static int sst_fill_module_list(struct snd_kcontrol *kctl,
         struct snd_soc_dapm_widget *w, int type)
 {
-       struct sst_module *module = NULL;
+       struct sst_module *module;
        struct snd_soc_component *c = snd_soc_dapm_to_component(w->dapm);
        struct sst_ids *ids = w->priv;
        int ret = 0;