vdpa/mlx5: fix error code for deleting vlan
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 7 Jun 2022 06:49:25 +0000 (09:49 +0300)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 8 Jun 2022 12:56:03 +0000 (08:56 -0400)
Return success if we were able to delete a vlan.  The current code
always returns failure.

Fixes: baf2ad3f6a98 ("vdpa/mlx5: Add RX MAC VLAN filter support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Message-Id: <Yp709f1g9NcMBCHg@kili>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Eli Cohen <elic@nvidia.com>
Acked-by: Si-Wei Liu <si-wei.liu@oracle.com>
drivers/vdpa/mlx5/net/mlx5_vnet.c

index b878c10955308a727f7b6d7c8b0a9ce0074c4018..51fb15c35e4268f3c55aa0bd71e1cf9cbf16564e 100644 (file)
@@ -1814,6 +1814,7 @@ static virtio_net_ctrl_ack handle_ctrl_vlan(struct mlx5_vdpa_dev *mvdev, u8 cmd)
 
                id = mlx5vdpa16_to_cpu(mvdev, vlan);
                mac_vlan_del(ndev, ndev->config.mac, id, true);
+               status = VIRTIO_NET_OK;
                break;
        default:
        break;