rtlwifi: rtl8192c-common: fix bool comparison in expressions
authorAditya Srivastava <yashsri421@gmail.com>
Sun, 10 Jan 2021 12:15:22 +0000 (17:45 +0530)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 25 Jan 2021 14:21:05 +0000 (16:21 +0200)
There are certain conditional expressions in rtl8192c-common, where a
boolean variable is compared with true/false, in forms such as
(foo == true) or (false != bar), which does not comply with checkpatch.pl
(CHECK: BOOL_COMPARISON), according to which boolean variables should be
themselves used in the condition, rather than comparing with true/false

E.g., in drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c,
"else if (initialized == false) {" can be replaced with
"else if (!initialized) {"

Replace all such expressions with the bool variables appropriately

Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210110121525.2407-3-yashsri421@gmail.com
drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c

index 265a1a336304e86ea0b0f969b22e3a21abf7f035..0b6a15c2e5ccde03a806daf75cf6f7c5c1f562f6 100644 (file)
@@ -380,7 +380,7 @@ static void rtl92c_dm_initial_gain_multi_sta(struct ieee80211_hw *hw)
                initialized = false;
                dm_digtable->dig_ext_port_stage = DIG_EXT_PORT_STAGE_MAX;
                return;
-       } else if (initialized == false) {
+       } else if (!initialized) {
                initialized = true;
                dm_digtable->dig_ext_port_stage = DIG_EXT_PORT_STAGE_0;
                dm_digtable->cur_igvalue = 0x20;
@@ -509,7 +509,7 @@ static void rtl92c_dm_dig(struct ieee80211_hw *hw)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
 
-       if (rtlpriv->dm.dm_initialgain_enable == false)
+       if (!rtlpriv->dm.dm_initialgain_enable)
                return;
        if (!(rtlpriv->dm.dm_flag & DYNAMIC_FUNC_DIG))
                return;