cpufreq: qcom-hw: Disable LMH irq when disabling policy
authorPierre Gondois <pierre.gondois@arm.com>
Mon, 4 Jul 2022 11:27:37 +0000 (13:27 +0200)
committerViresh Kumar <viresh.kumar@linaro.org>
Wed, 13 Jul 2022 11:23:00 +0000 (16:53 +0530)
If LMH (Limits Management Hardware) is available, when a policy is
disabled by unplugging the last online CPU of policy->cpus, the LMH
irq is left enabled.
When the policy is re-enabled with any of the CPU in policy->cpus
being plugged in, qcom_cpufreq_ready() re-enables the irq. This
triggers the following warning:
[  379.160106] Unbalanced enable for IRQ 154
[  379.160120] WARNING: CPU: 7 PID: 48 at kernel/irq/manage.c:774 __enable_irq+0x84/0xc0
Thus disable the irq.

Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/qcom-cpufreq-hw.c

index b57a1e508a8ca4322de1a83754b3148fc0380973..6e3deb42035906d48a5d57ed89a2addaec95b90e 100644 (file)
@@ -469,6 +469,7 @@ static int qcom_cpufreq_hw_cpu_offline(struct cpufreq_policy *policy)
 
        cancel_delayed_work_sync(&data->throttle_work);
        irq_set_affinity_hint(data->throttle_irq, NULL);
+       disable_irq_nosync(data->throttle_irq);
 
        return 0;
 }