media: v4l2: fix uninitialized value tuner_status(CWE-457)
authorYan Lei <yan_lei@dahuatech.com>
Sun, 10 Apr 2022 01:58:54 +0000 (02:58 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Sun, 24 Apr 2022 07:49:53 +0000 (08:49 +0100)
Declaring variable "tuner_status" without initializer.
Using uninitialized value "tuner_status" when calling
"*fe_tuner_ops->get_status".
(The function pointer resolves to "cx24113_get_status".)

Signed-off-by: Yan Lei <yan_lei@dahuatech.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/v4l2-core/tuner-core.c

index ad9224a18853979245efe6f6540fd372eb7b2967..2d47c10de0624e0c41f118cecd0bc0347a3d644a 100644 (file)
@@ -1118,7 +1118,7 @@ static void tuner_status(struct dvb_frontend *fe)
        if (t->mode != V4L2_TUNER_RADIO)
                return;
        if (fe_tuner_ops->get_status) {
-               u32 tuner_status;
+               u32 tuner_status = 0;
 
                fe_tuner_ops->get_status(&t->fe, &tuner_status);
                if (tuner_status & TUNER_STATUS_LOCKED)
@@ -1258,7 +1258,7 @@ static int tuner_g_tuner(struct v4l2_subdev *sd, struct v4l2_tuner *vt)
        if (vt->type == t->mode) {
                vt->rxsubchans = V4L2_TUNER_SUB_MONO | V4L2_TUNER_SUB_STEREO;
                if (fe_tuner_ops->get_status) {
-                       u32 tuner_status;
+                       u32 tuner_status = 0;
 
                        fe_tuner_ops->get_status(&t->fe, &tuner_status);
                        vt->rxsubchans =