Input: lpc32xx-keys - remove an unused field in struct lpc32xx_kscan_drv
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Wed, 1 May 2024 06:39:23 +0000 (08:39 +0200)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 6 May 2024 22:41:37 +0000 (15:41 -0700)
In "struct lpc32xx_kscan_drv", the 'irq' field is unused.
Remove it.

Found with cppcheck, unusedStructMember.

While at it, move the 'row_shift' field in order to fill a hole in the
structure (at least on 64 bits arch).

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/e006dfb77e35762c6e4f8ba6ba792b0c52fde375.1714545542.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/lpc32xx-keys.c

index 322a878071591dc11a470f9afc4b38f8c9cc3cde..423035be86fb83d6f85d6e86a48068043fc1f84a 100644 (file)
@@ -57,14 +57,13 @@ struct lpc32xx_kscan_drv {
        struct input_dev *input;
        struct clk *clk;
        void __iomem *kscan_base;
-       unsigned int irq;
 
        u32 matrix_sz;          /* Size of matrix in XxY, ie. 3 = 3x3 */
        u32 deb_clks;           /* Debounce clocks (based on 32KHz clock) */
        u32 scan_delay;         /* Scan delay (based on 32KHz clock) */
 
-       unsigned short *keymap; /* Pointer to key map for the scan matrix */
        unsigned int row_shift;
+       unsigned short *keymap; /* Pointer to key map for the scan matrix */
 
        u8 lastkeystates[8];
 };