i2c: hix5hd2: Remove IRQF_ONESHOT
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Tue, 13 Aug 2019 11:55:55 +0000 (13:55 +0200)
committerWolfram Sang <wsa@the-dreams.de>
Tue, 3 Sep 2019 18:01:13 +0000 (20:01 +0200)
The drivers sets IRQF_ONESHOT and passes only a primary handler. The IRQ
is masked while the primary is handler is invoked independently of
IRQF_ONESHOT.
With IRQF_ONESHOT the core code will not force-thread the interrupt and
this is probably not intended. I *assume* that the original author copied
the IRQ registration from another driver which passed a primary and
secondary handler and removed the secondary handler but keeping the
ONESHOT flag.

Remove IRQF_ONESHOT.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-hix5hd2.c

index 4df1434b3597da315b55c7bdb21dd585a4901b7c..8497c7a95dd44e85d3158289182a2a008e25d532 100644 (file)
@@ -445,8 +445,7 @@ static int hix5hd2_i2c_probe(struct platform_device *pdev)
        hix5hd2_i2c_init(priv);
 
        ret = devm_request_irq(&pdev->dev, irq, hix5hd2_i2c_irq,
-                              IRQF_NO_SUSPEND | IRQF_ONESHOT,
-                              dev_name(&pdev->dev), priv);
+                              IRQF_NO_SUSPEND, dev_name(&pdev->dev), priv);
        if (ret != 0) {
                dev_err(&pdev->dev, "cannot request HS-I2C IRQ %d\n", irq);
                goto err_clk;