staging: r8188eu: remove rf_type from issue_assocreq()
authorMichael Straube <straube.linux@gmail.com>
Sun, 28 Nov 2021 17:09:16 +0000 (18:09 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Dec 2021 14:13:36 +0000 (15:13 +0100)
rf_type is always RF_1T1R. Remove it from issue_assocreq() and remove
related dead code.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20211128170924.5874-3-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_mlme_ext.c

index b4820ad2cee735f2bf16bada6e7d143de90b6f76..be9a77daf26ebe56cbbd03e6922094636d821a59 100644 (file)
@@ -5062,7 +5062,7 @@ void issue_assocreq(struct adapter *padapter)
        __le16 *fctrl;
        __le16          le_tmp;
        unsigned int    i, j, ie_len, index = 0;
-       unsigned char   rf_type, bssrate[NumRates], sta_bssrate[NumRates];
+       unsigned char bssrate[NumRates], sta_bssrate[NumRates];
        struct ndis_802_11_var_ie *pIE;
        struct registry_priv    *pregpriv = &padapter->registrypriv;
        struct xmit_priv                *pxmitpriv = &padapter->xmitpriv;
@@ -5187,25 +5187,10 @@ void issue_assocreq(struct adapter *padapter)
                        /* todo: disable SM power save mode */
                        pmlmeinfo->HT_caps.u.HT_cap_element.HT_caps_info |= cpu_to_le16(0x000c);
 
-                       GetHwReg8188EU(padapter, HW_VAR_RF_TYPE, (u8 *)(&rf_type));
-                       switch (rf_type) {
-                       case RF_1T1R:
-                               if (pregpriv->rx_stbc)
-                                       pmlmeinfo->HT_caps.u.HT_cap_element.HT_caps_info |= cpu_to_le16(0x0100);/* RX STBC One spatial stream */
-                               memcpy(pmlmeinfo->HT_caps.u.HT_cap_element.MCS_rate, MCS_rate_1R, 16);
-                               break;
-                       case RF_2T2R:
-                       case RF_1T2R:
-                       default:
-                               if ((pregpriv->rx_stbc == 0x3) ||/* enable for 2.4/5 GHz */
-                                   ((pmlmeext->cur_wireless_mode & WIRELESS_11_24N) && (pregpriv->rx_stbc == 0x1)) || /* enable for 2.4GHz */
-                                   (pregpriv->wifi_spec == 1)) {
-                                       DBG_88E("declare supporting RX STBC\n");
-                                       pmlmeinfo->HT_caps.u.HT_cap_element.HT_caps_info |= cpu_to_le16(0x0200);/* RX STBC two spatial stream */
-                               }
-                               memcpy(pmlmeinfo->HT_caps.u.HT_cap_element.MCS_rate, MCS_rate_2R, 16);
-                               break;
-                       }
+                       if (pregpriv->rx_stbc)
+                               pmlmeinfo->HT_caps.u.HT_cap_element.HT_caps_info |= cpu_to_le16(0x0100);/* RX STBC One spatial stream */
+                       memcpy(pmlmeinfo->HT_caps.u.HT_cap_element.MCS_rate, MCS_rate_1R, 16);
+
                        pframe = rtw_set_ie(pframe, _HT_CAPABILITY_IE_, ie_len, (u8 *)(&pmlmeinfo->HT_caps), &pattrib->pktlen);
                }
        }