staging: vc04_services: vchiq_core: Log through struct vchiq_instance

The handle_to_service() helper can return NULL, so `service` pointer
can indeed be set to NULL. So, do not log through service pointer
(which can cause NULL-deference), instead, use the vchiq_instance
function argument to get access to the struct device.

Fixes: f67af5940d6d ("staging: vc04: Convert(and rename) vchiq_log_info() to use dynamic debug")
Reviewed-by: Ricardo B. Marliere <ricardo@marliere.net>
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/20231128201845.489237-1-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
index 0468689a6325b24ec2687de77cdc287be3f18afe..e0022acb4c5851058b1a69746675b17d1fa49883 100644 (file)
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
@@ -245,7 +245,7 @@ find_service_by_handle(struct vchiq_instance *instance, unsigned int handle)
                return service;
        }
        rcu_read_unlock();
-       vchiq_log_debug(service->state->dev, VCHIQ_CORE,
+       vchiq_log_debug(instance->state->dev, VCHIQ_CORE,
                        "Invalid service handle 0x%x", handle);
        return NULL;
 }
@@ -287,7 +287,7 @@ find_service_for_instance(struct vchiq_instance *instance, unsigned int handle)
                return service;
        }
        rcu_read_unlock();
-       vchiq_log_debug(service->state->dev, VCHIQ_CORE,
+       vchiq_log_debug(instance->state->dev, VCHIQ_CORE,
                        "Invalid service handle 0x%x", handle);
        return NULL;
 }
@@ -310,7 +310,7 @@ find_closed_service_for_instance(struct vchiq_instance *instance, unsigned int h
                return service;
        }
        rcu_read_unlock();
-       vchiq_log_debug(service->state->dev, VCHIQ_CORE,
+       vchiq_log_debug(instance->state->dev, VCHIQ_CORE,
                        "Invalid service handle 0x%x", handle);
        return service;
 }