scsi: mpi3mr: Fix missing unlock on error

Goto unlock path before return from function in the error handling case.

Link: https://lore.kernel.org/r/20210603152803.717505-1-yangyingliang@huawei.com
Fixes: c9566231cfaf ("scsi: mpi3mr: Create operational request and reply queue pair")
Reported-by: Hulk Robot <hulkci@huawei.com>
Acked-by: Kashyap Desai <kashyap.desai@broadcom.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/mpi3mr/mpi3mr_fw.c b/drivers/scsi/mpi3mr/mpi3mr_fw.c
index 88db2f0e13fd73c6d2e71146c8a420df60e67b47..20452576d7d6fbdabe4bf0b23c1fc3a4cad87ea5 100644 (file)
--- a/drivers/scsi/mpi3mr/mpi3mr_fw.c
+++ b/drivers/scsi/mpi3mr/mpi3mr_fw.c
@@ -1585,7 +1585,7 @@ static int mpi3mr_create_op_reply_q(struct mpi3mr_ioc *mrioc, u16 qidx)
        if (mrioc->init_cmds.state & MPI3MR_CMD_PENDING) {
                retval = -1;
                ioc_err(mrioc, "CreateRepQ: Init command is in use\n");
-               goto out;
+               goto out_unlock;
        }
        mrioc->init_cmds.state = MPI3MR_CMD_PENDING;
        mrioc->init_cmds.is_waiting = 1;
@@ -1694,7 +1694,7 @@ static int mpi3mr_create_op_req_q(struct mpi3mr_ioc *mrioc, u16 idx,
        if (mrioc->init_cmds.state & MPI3MR_CMD_PENDING) {
                retval = -1;
                ioc_err(mrioc, "CreateReqQ: Init command is in use\n");
-               goto out;
+               goto out_unlock;
        }
        mrioc->init_cmds.state = MPI3MR_CMD_PENDING;
        mrioc->init_cmds.is_waiting = 1;