bcachefs: Delete bch_writepage
authorKent Overstreet <kent.overstreet@gmail.com>
Thu, 5 May 2022 21:20:41 +0000 (17:20 -0400)
committerKent Overstreet <kent.overstreet@linux.dev>
Sun, 22 Oct 2023 21:09:32 +0000 (17:09 -0400)
Per Dave Chinner and the xfs folks, .writepage is no longer needed, and
it's better not to define it if .writepages is the intended path.

Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
fs/bcachefs/fs-io.c
fs/bcachefs/fs-io.h
fs/bcachefs/fs.c

index 256b3dd0d4aa46a82ca6f390a692f44854a9312a..ad51483ad764ae8647b3818d48c7bba72e8e97a5 100644 (file)
@@ -1469,20 +1469,6 @@ int bch2_writepages(struct address_space *mapping, struct writeback_control *wbc
        return ret;
 }
 
-int bch2_writepage(struct page *page, struct writeback_control *wbc)
-{
-       struct bch_fs *c = page->mapping->host->i_sb->s_fs_info;
-       struct bch_writepage_state w =
-               bch_writepage_state_init(c, to_bch_ei(page->mapping->host));
-       int ret;
-
-       ret = __bch2_writepage(page_folio(page), wbc, &w);
-       if (w.io)
-               bch2_writepage_do_io(&w);
-
-       return ret;
-}
-
 /* buffered writes: */
 
 int bch2_write_begin(struct file *file, struct address_space *mapping,
index 64b16b44e25ae57e733306a57c297893d635390d..af905331542dd99191b43866ee423991764a8e66 100644 (file)
@@ -15,7 +15,6 @@ int __must_check bch2_write_inode_size(struct bch_fs *,
                                       struct bch_inode_info *,
                                       loff_t, unsigned);
 
-int bch2_writepage(struct page *, struct writeback_control *);
 int bch2_read_folio(struct file *, struct folio *);
 
 int bch2_writepages(struct address_space *, struct writeback_control *);
index d8cd32b5d765eee1e3312569a066a9b386246cdb..b2bc28d0cf0511355199961f5a23abb1cd8c5b3d 100644 (file)
@@ -1113,7 +1113,6 @@ static const struct inode_operations bch_special_inode_operations = {
 };
 
 static const struct address_space_operations bch_address_space_operations = {
-       .writepage      = bch2_writepage,
        .read_folio     = bch2_read_folio,
        .writepages     = bch2_writepages,
        .readahead      = bch2_readahead,