wifi: ath10k: Drop checks that are always false

platform_get_drvdata() cannot return NULL as the probe function calls
platform_set_drvdata() with a non-NULL argument or returns with a failure.
In the first case, platform_get_drvdata() returns this non-NULL value and
in the second the remove callback isn't called at all.

ath10k_ahb_priv() cannot return NULL and ar_ahb is unused after the check
anyhow.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230601082556.2738446-3-u.kleine-koenig@pengutronix.de

diff --git a/drivers/net/wireless/ath/ath10k/ahb.c b/drivers/net/wireless/ath/ath10k/ahb.c
index 7bb45c66cff7e6a1cee723cf19b0cdcb4638ceef..fffdbad750749c15823f475cd24179d2a527a0cd 100644 (file)
--- a/drivers/net/wireless/ath/ath10k/ahb.c
+++ b/drivers/net/wireless/ath/ath10k/ahb.c
@@ -823,15 +823,6 @@ err_core_destroy:
 static int ath10k_ahb_remove(struct platform_device *pdev)
 {
        struct ath10k *ar = platform_get_drvdata(pdev);
-       struct ath10k_ahb *ar_ahb;
-
-       if (!ar)
-               return -EINVAL;
-
-       ar_ahb = ath10k_ahb_priv(ar);
-
-       if (!ar_ahb)
-               return -EINVAL;
 
        ath10k_dbg(ar, ATH10K_DBG_AHB, "ahb remove\n");