remoteproc: meson-mx-ao-arc: fix a bit test
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 4 Oct 2021 10:52:57 +0000 (13:52 +0300)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Mon, 4 Oct 2021 15:40:29 +0000 (10:40 -0500)
The MESON_AO_RPROC_SRAM_USABLE_BITS macro is used like this:

        if (priv->sram_pa & ~MESON_AO_RPROC_SRAM_USABLE_BITS) {
                dev_err(dev, "SRAM address contains unusable bits\n");

The problem is that "->sram_pa" is type phys_addr_t which is potentially
64 bits.  That means the MESON_AO_RPROC_SRAM_USABLE_BITS macro needs to
be a 64 bit type as well to ensure that high 32 bits are cleared.

Fixes: 6cb58ea897dd ("remoteproc: meson-mx-ao-arc: Add a driver for the AO ARC remote procesor")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20211004105257.GA27301@kili
drivers/remoteproc/meson_mx_ao_arc.c

index 3d8f927ae448fe94ff704970319d2e9c59b52c18..462cddab6518d73790f7ff2322093fdc3c8b2ca3 100644 (file)
@@ -39,7 +39,7 @@
 #define AO_SECURE_REG0_AHB_SRAM_BITS_19_12                     GENMASK(15, 8)
 
 /* Only bits [31:20] and [17:14] are usable, all other bits must be zero */
-#define MESON_AO_RPROC_SRAM_USABLE_BITS                                0xfff3c000
+#define MESON_AO_RPROC_SRAM_USABLE_BITS                                0xfff3c000ULL
 
 #define MESON_AO_RPROC_MEMORY_OFFSET                           0x10000000