leds: aw2013: Use devm API to cleanup module's resources

In this driver LEDs are registered using devm_led_classdev_register()
so they are automatically unregistered after module's remove() is done.
led_classdev_unregister() calls module's led_set_brightness() to turn off
the LEDs and that callback uses resources which were destroyed already
in module's remove() so use devm API instead of remove().

Signed-off-by: George Stark <gnstark@salutedevices.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Tested-by: Nikita Travkin <nikita@trvn.ru>
Link: https://lore.kernel.org/r/20240411161032.609544-3-gnstark@salutedevices.com
Signed-off-by: Lee Jones <lee@kernel.org>

diff --git a/drivers/leds/leds-aw2013.c b/drivers/leds/leds-aw2013.c
index 17235a5e576aef330a4f59e0e2d3f84e1af0ff9c..6475eadcb0df94c433823dd4d2e671057e3c515e 100644 (file)
--- a/drivers/leds/leds-aw2013.c
+++ b/drivers/leds/leds-aw2013.c
@@ -320,6 +320,11 @@ static int aw2013_probe_dt(struct aw2013 *chip)
        return 0;
 }
 
+static void aw2013_chip_disable_action(void *data)
+{
+       aw2013_chip_disable(data);
+}
+
 static const struct regmap_config aw2013_regmap_config = {
        .reg_bits = 8,
        .val_bits = 8,
@@ -336,7 +341,10 @@ static int aw2013_probe(struct i2c_client *client)
        if (!chip)
                return -ENOMEM;
 
-       mutex_init(&chip->mutex);
+       ret = devm_mutex_init(&client->dev, &chip->mutex);
+       if (ret)
+               return ret;
+
        mutex_lock(&chip->mutex);
 
        chip->client = client;
@@ -384,6 +392,10 @@ static int aw2013_probe(struct i2c_client *client)
                goto error_reg;
        }
 
+       ret = devm_add_action(&client->dev, aw2013_chip_disable_action, chip);
+       if (ret)
+               goto error_reg;
+
        ret = aw2013_probe_dt(chip);
        if (ret < 0)
                goto error_reg;
@@ -406,19 +418,9 @@ error_reg:
 
 error:
        mutex_unlock(&chip->mutex);
-       mutex_destroy(&chip->mutex);
        return ret;
 }
 
-static void aw2013_remove(struct i2c_client *client)
-{
-       struct aw2013 *chip = i2c_get_clientdata(client);
-
-       aw2013_chip_disable(chip);
-
-       mutex_destroy(&chip->mutex);
-}
-
 static const struct of_device_id aw2013_match_table[] = {
        { .compatible = "awinic,aw2013", },
        { /* sentinel */ },
@@ -432,7 +434,6 @@ static struct i2c_driver aw2013_driver = {
                .of_match_table = aw2013_match_table,
        },
        .probe = aw2013_probe,
-       .remove = aw2013_remove,
 };
 
 module_i2c_driver(aw2013_driver);