wifi: rtl8xxxu: Add LED control code for RTL8192CU family

Also, don't set bit 7 of LEDCFG2 for RTL8192CU. If bit 7 is set the LED
never turns on. In this family only RTL8188CUS needs bit 7 of LEDCFG2
set.

Software control (on/off) and hardware control (automatic blinking)
tested with Netcore NW362 (RTL8192CU).

Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://msgid.link/4b5970cf-d28b-415a-b911-82cdb5e9ce99@gmail.com

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192c.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192c.c
index e54978ca717169ec154d2f97ad7fd1eb71bf8186..ddf2d9707338d63f3c3c810dc53cf03a683c556d 100644 (file)
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192c.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192c.c
@@ -609,6 +609,26 @@ static int rtl8192cu_power_on(struct rtl8xxxu_priv *priv)
        return 0;
 }
 
+static int rtl8192cu_led_brightness_set(struct led_classdev *led_cdev,
+                                       enum led_brightness brightness)
+{
+       struct rtl8xxxu_priv *priv = container_of(led_cdev,
+                                                 struct rtl8xxxu_priv,
+                                                 led_cdev);
+       u8 ledcfg = rtl8xxxu_read8(priv, REG_LEDCFG0);
+
+       if (brightness == LED_OFF)
+               ledcfg = LEDCFG2_SW_LED_CONTROL | LEDCFG2_SW_LED_DISABLE;
+       else if (brightness == LED_ON)
+               ledcfg = LEDCFG2_SW_LED_CONTROL;
+       else if (brightness == RTL8XXXU_HW_LED_CONTROL)
+               ledcfg = LEDCFG2_HW_LED_CONTROL | LEDCFG2_HW_LED_ENABLE;
+
+       rtl8xxxu_write8(priv, REG_LEDCFG0, ledcfg);
+
+       return 0;
+}
+
 struct rtl8xxxu_fileops rtl8192cu_fops = {
        .identify_chip = rtl8192cu_identify_chip,
        .parse_efuse = rtl8192cu_parse_efuse,
@@ -635,6 +655,7 @@ struct rtl8xxxu_fileops rtl8192cu_fops = {
        .report_rssi = rtl8xxxu_gen1_report_rssi,
        .fill_txdesc = rtl8xxxu_fill_txdesc_v1,
        .cck_rssi = rtl8723a_cck_rssi,
+       .led_classdev_brightness_set = rtl8192cu_led_brightness_set,
        .writeN_block_size = 128,
        .rx_agg_buf_size = 16000,
        .tx_desc_size = sizeof(struct rtl8xxxu_txdesc32),

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index 464772866a227ab2e279a8e1b0a7d0d7619274a5..e72f35a40ab3ccc31ce3ef790480d114c5003de0 100644 (file)
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -4355,7 +4355,7 @@ static int rtl8xxxu_init_device(struct ieee80211_hw *hw)
 
        /* Let the 8051 take control of antenna setting */
        if (priv->rtl_chip != RTL8192E && priv->rtl_chip != RTL8188F &&
-           priv->rtl_chip != RTL8710B) {
+           priv->rtl_chip != RTL8710B && priv->rtl_chip != RTL8192C) {
                val8 = rtl8xxxu_read8(priv, REG_LEDCFG2);
                val8 |= LEDCFG2_DPDT_SELECT;
                rtl8xxxu_write8(priv, REG_LEDCFG2, val8);