staging: rtl8723bs: os_dep: remove set but not used 'uintRet'
authorJason Yan <yanaijie@huawei.com>
Mon, 27 Apr 2020 03:23:36 +0000 (11:23 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 28 Apr 2020 12:29:41 +0000 (14:29 +0200)
Fix the following gcc warning:

drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2564:22: warning:
variable â€˜uintRet’ set but not used [-Wunused-but-set-variable]
         unsigned int uintRet = 0;
                      ^~~~~~~

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Link: https://lore.kernel.org/r/20200427032342.27211-2-yanaijie@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c

index 5059b874080e9e41f818cbecbdf3a774392215f5..902ac81699484b0731cfdd4f4881822f98d352df 100644 (file)
@@ -2561,14 +2561,16 @@ static int rtw_wps_start(struct net_device *dev,
        struct adapter *padapter = (struct adapter *)rtw_netdev_priv(dev);
        struct iw_point *pdata = &wrqu->data;
        u32   u32wps_start = 0;
-        unsigned int uintRet = 0;
 
        if ((true == padapter->bDriverStopped) || (true == padapter->bSurpriseRemoved) || (NULL == pdata)) {
                ret = -EINVAL;
                goto exit;
        }
 
-       uintRet = copy_from_user((void *)&u32wps_start, pdata->pointer, 4);
+       if (copy_from_user((void *)&u32wps_start, pdata->pointer, 4)) {
+               ret = -EFAULT;
+               goto exit;
+       }
        if (u32wps_start == 0)
                u32wps_start = *extra;