crypto: qat - return error when failing to map FW
authorJack Xu <jack.xu@intel.com>
Mon, 17 May 2021 09:13:12 +0000 (05:13 -0400)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 28 May 2021 06:20:40 +0000 (14:20 +0800)
Save the return value of qat_uclo_map_auth_fw() function so that the
function qat_uclo_wr_mimage() could return the correct value.
This way, the procedure of adf_gen2_ae_fw_load() function could stop
and exit properly by checking the return value of qat_uclo_wr_mimage().

Signed-off-by: Jack Xu <jack.xu@intel.com>
Co-developed-by: Zhehui Xiang <zhehui.xiang@intel.com>
Signed-off-by: Zhehui Xiang <zhehui.xiang@intel.com>
Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/qat/qat_common/qat_uclo.c

index 1fb5fc852f6b86d361056ea20caf5fba142a861e..d2c2db58c93ffdf5e9661e2954b56191cf8f8d39 100644 (file)
@@ -1546,7 +1546,8 @@ int qat_uclo_wr_mimage(struct icp_qat_fw_loader_handle *handle,
        int status = 0;
 
        if (handle->chip_info->fw_auth) {
-               if (!qat_uclo_map_auth_fw(handle, addr_ptr, mem_size, &desc))
+               status = qat_uclo_map_auth_fw(handle, addr_ptr, mem_size, &desc);
+               if (!status)
                        status = qat_uclo_auth_fw(handle, desc);
                qat_uclo_ummap_auth_fw(handle, &desc);
        } else {