soundwire: bus: add enumerated Slave device to device list

Currently Slave devices are only added on startup, either from Device
Tree or ACPI entries. However Slave devices that are physically
present on the bus, but not described in platform firmware, will never
be added to the device list. The user/integrator can only know the
list of devices by looking a dynamic debug logs.

This patch suggests adding a Slave device even if there is no matching
DT or ACPI entry, so that we can see this in sysfs entry.

Initial code from Srinivas. Comments, fixes for ACPI probe and edits
of commit message by Pierre.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Co-developed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200924194430.121058-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index e3fe53f38708075e56d63e3e0fc25d695bb3e487..f4c7887c3234de4bbfa7235ffcc5f88d808ac2b0 100644 (file)
--- a/drivers/soundwire/bus.c
+++ b/drivers/soundwire/bus.c
@@ -747,6 +747,15 @@ static int sdw_program_device_num(struct sdw_bus *bus)
 
                if (!found) {
                        /* TODO: Park this device in Group 13 */
+
+                       /*
+                        * add Slave device even if there is no platform
+                        * firmware description. There will be no driver probe
+                        * but the user/integration will be able to see the
+                        * device, enumeration status and device number in sysfs
+                        */
+                       sdw_slave_add(bus, &id, NULL);
+
                        dev_err(bus->dev, "Slave Entry not found\n");
                }
 

diff --git a/drivers/soundwire/bus.h b/drivers/soundwire/bus.h
index e0703991aad97cafefda3c61b49408cce90e7d10..2e049d39c6e5c667c7906174e49210688966f323 100644 (file)
--- a/drivers/soundwire/bus.h
+++ b/drivers/soundwire/bus.h
@@ -19,6 +19,8 @@ static inline int sdw_acpi_find_slaves(struct sdw_bus *bus)
 int sdw_of_find_slaves(struct sdw_bus *bus);
 void sdw_extract_slave_id(struct sdw_bus *bus,
                          u64 addr, struct sdw_slave_id *id);
+int sdw_slave_add(struct sdw_bus *bus, struct sdw_slave_id *id,
+                 struct fwnode_handle *fwnode);
 int sdw_master_device_add(struct sdw_bus *bus, struct device *parent,
                          struct fwnode_handle *fwnode);
 int sdw_master_device_del(struct sdw_bus *bus);

diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c
index 6fba55898cf025324761f20db456e748955a64f5..575b9bad99d510459fca1fed8fc22bc4e1f2af64 100644 (file)
--- a/drivers/soundwire/bus_type.c
+++ b/drivers/soundwire/bus_type.c
@@ -84,6 +84,15 @@ static int sdw_drv_probe(struct device *dev)
        const struct sdw_device_id *id;
        int ret;
 
+       /*
+        * fw description is mandatory to bind
+        */
+       if (!dev->fwnode)
+               return -ENODEV;
+
+       if (!IS_ENABLED(CONFIG_ACPI) && !dev->of_node)
+               return -ENODEV;
+
        id = sdw_get_device_id(slave, drv);
        if (!id)
                return -ENODEV;

diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c
index 4a250d33de5d0731e351ed286bec934847e5ba6e..19b012310c295836673d57614813438047835684 100644 (file)
--- a/drivers/soundwire/slave.c
+++ b/drivers/soundwire/slave.c
@@ -20,8 +20,8 @@ struct device_type sdw_slave_type = {
        .uevent =       sdw_slave_uevent,
 };
 
-static int sdw_slave_add(struct sdw_bus *bus,
-                        struct sdw_slave_id *id, struct fwnode_handle *fwnode)
+int sdw_slave_add(struct sdw_bus *bus,
+                 struct sdw_slave_id *id, struct fwnode_handle *fwnode)
 {
        struct sdw_slave *slave;
        int ret;