wifi: iwlwifi: mvm: remove warning for beacon filtering error

This warning is sometimes happening if we force a FW error
while disconnecting, which is annoying but harmless.

However, it's also pointless to throw a warning here, since
the stack and driver state doesn't really help, so just
remove that so the driver will ignore the error if any.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230531194630.29fe6990d372.I00ff5dc7bfb4025a609f380a0a3911d842b72449@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
index 7ea200c85cac8e099bd88b467d90443d5f94c28b..6a712e519bac39076411993aba42acbcca3f959c 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
@@ -3801,7 +3801,6 @@ iwl_mvm_sta_state_authorized_to_assoc(struct iwl_mvm *mvm,
 {
        struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif);
        struct iwl_mvm_sta *mvmsta = iwl_mvm_sta_from_mac80211(sta);
-       int ret;
 
        lockdep_assert_held(&mvm->mutex);
 
@@ -3820,10 +3819,7 @@ iwl_mvm_sta_state_authorized_to_assoc(struct iwl_mvm *mvm,
                mvmvif->authorized = 0;
 
                /* disable beacon filtering */
-               ret = iwl_mvm_disable_beacon_filter(mvm, vif, 0);
-               WARN_ON(ret &&
-                       !test_bit(IWL_MVM_STATUS_HW_RESTART_REQUESTED,
-                                 &mvm->status));
+               iwl_mvm_disable_beacon_filter(mvm, vif, 0);
        }
 
        return 0;