clocksource/drivers/exynos_mct: Explicitly return 0 for shared timer
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Mon, 3 Apr 2023 09:40:17 +0000 (11:40 +0200)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Mon, 24 Apr 2023 14:56:13 +0000 (16:56 +0200)
For a shared timers, the mct_init_dt() should not initialize the clock
even with global comparator.  This is not an error, thus the function
should simply return 0, not 'ret'.

This also fixes smatch warning:

  drivers/clocksource/exynos_mct.c:635 mct_init_dt() warn: missing error code? 'ret'

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/r/202304021446.46XVKag0-lkp@intel.com/
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230403094017.9556-1-krzysztof.kozlowski@linaro.org
drivers/clocksource/exynos_mct.c

index bfd60093ee1c934c91a4a5d1dec1f583ba0f12fc..ef8cb1b71be4a8fba64759641f640809aaf9e80c 100644 (file)
@@ -682,7 +682,7 @@ static int __init mct_init_dt(struct device_node *np, unsigned int int_type)
         * processor cannot use the global comparator.
         */
        if (frc_shared)
-               return ret;
+               return 0;
 
        return exynos4_clockevent_init();
 }