tls: stop recv() if initial process_rx_list gave us non-DATA
authorSabrina Dubroca <sd@queasysnail.net>
Thu, 15 Feb 2024 16:17:30 +0000 (17:17 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 21 Feb 2024 22:25:51 +0000 (14:25 -0800)
If we have a non-DATA record on the rx_list and another record of the
same type still on the queue, we will end up merging them:
 - process_rx_list copies the non-DATA record
 - we start the loop and process the first available record since it's
   of the same type
 - we break out of the loop since the record was not DATA

Just check the record type and jump to the end in case process_rx_list
did some work.

Fixes: 692d7b5d1f91 ("tls: Fix recvmsg() to be able to peek across multiple records")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Link: https://lore.kernel.org/r/bd31449e43bd4b6ff546f5c51cf958c31c511deb.1708007371.git.sd@queasysnail.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/tls/tls_sw.c

index 78aedfc682ba84c62e2fb71ac09e605593c43f03..43dd0d82b6ed7af7f96b205bb17568adb9f687a7 100644 (file)
@@ -1971,7 +1971,7 @@ int tls_sw_recvmsg(struct sock *sk,
                goto end;
 
        copied = err;
-       if (len <= copied)
+       if (len <= copied || (copied && control != TLS_RECORD_TYPE_DATA))
                goto end;
 
        target = sock_rcvlowat(sk, flags & MSG_WAITALL, len);