i2c: slave-eeprom: Add comment about address handling
authorBjörn Ardö <bjorn.ardo@axis.com>
Thu, 5 Sep 2019 14:50:26 +0000 (16:50 +0200)
committerWolfram Sang <wsa@the-dreams.de>
Thu, 5 Sep 2019 20:26:04 +0000 (22:26 +0200)
The behaviour of the EEPROM in the case where we only send an 8bit
address to a 16bit address EEPROM is not defined. Added comment about
that the slave-eeprom might behave differently from how an actual device
does (only one model measured).

Reported-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Björn Ardö <bjorn.ardo@axis.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/i2c-slave-eeprom.c

index 773afaabfb61f2c1d8dbd68717b0ad15cb9d2f8a..92ff9991bae81bd1390075e752b82395008c2f3d 100644 (file)
  * pointer, yet implementation is deferred until the need actually arises.
  */
 
+/*
+ * FIXME: What to do if only 8 bits of a 16 bit address are sent?
+ * The ST-M24C64 sends only 0xff then. Needs verification with other
+ * EEPROMs, though. We currently use the 8 bit as a valid address.
+ */
+
 #include <linux/bitfield.h>
 #include <linux/i2c.h>
 #include <linux/init.h>