posix-cpu-timers: Respect INFINITY for hard RTTIME limit
authorThomas Gleixner <tglx@linutronix.de>
Wed, 21 Aug 2019 19:09:17 +0000 (21:09 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 28 Aug 2019 09:50:39 +0000 (11:50 +0200)
The RTIME limit expiry code does not check the hard RTTIME limit for
INFINITY, i.e. being disabled.  Add it.

While this could be considered an ABI breakage if something would depend on
this behaviour. Though it's highly unlikely to have an effect because
RLIM_INFINITY is at minimum INT_MAX and the RTTIME limit is in seconds, so
the timer would fire after ~68 years.

Adding this obvious correct limit check also allows further consolidation
of that code and is a prerequisite for cleaning up the 0 based checks and
the rlimit setter code.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Link: https://lkml.kernel.org/r/20190821192922.078293002@linutronix.de
kernel/time/posix-cpu-timers.c

index e62139a89375720bd4e82cfb7256afbb925acb2e..a738d7659915e2d44552c0d6e637ef8f267c745f 100644 (file)
@@ -921,7 +921,7 @@ static void check_process_timers(struct task_struct *tsk,
                unsigned long hard = task_rlimit_max(tsk, RLIMIT_CPU);
                unsigned long psecs = div_u64(ptime, NSEC_PER_SEC);
 
-               if (psecs >= hard) {
+               if (hard != RLIM_INFINITY && psecs >= hard) {
                        /*
                         * At the hard limit, we just die.
                         * No need to calculate anything else now.