mtd: core: Don't fail mtd_otp_nvmem_add() if OTP is unsupported
authorAapo Vienamo <aapo.vienamo@linux.intel.com>
Wed, 13 Mar 2024 17:34:25 +0000 (19:34 +0200)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Mon, 25 Mar 2024 09:26:55 +0000 (10:26 +0100)
Handle the case where -EOPNOTSUPP is returned from OTP driver.

This addresses an issue that occurs with the Intel SPI flash controller,
which has a limited supported opcode set. Whilst the OTP functionality
is not available due to this restriction, other parts of the MTD
functionality of the device are intact. This change allows the driver
to gracefully handle the restriction by allowing the supported
functionality to remain available instead of failing the probe
altogether.

Signed-off-by: Aapo Vienamo <aapo.vienamo@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Michael Walle <mwalle@kernel.org>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20240313173425.1325790-3-aapo.vienamo@linux.intel.com
drivers/mtd/mtdcore.c

index c365c97e7232e3529872a89045874339784eaa6e..9e18422fdc770436b8b061a965f28500c7624b36 100644 (file)
@@ -1014,7 +1014,11 @@ static int mtd_otp_nvmem_add(struct mtd_info *mtd)
 
 err:
        nvmem_unregister(mtd->otp_user_nvmem);
-       return dev_err_probe(dev, err, "Failed to register OTP NVMEM device\n");
+       /* Don't report error if OTP is not supported. */
+       if (err != -EOPNOTSUPP)
+               return dev_err_probe(dev, err,
+                                    "Failed to register OTP NVMEM device\n");
+       return 0;
 }
 
 /**