RDMA/hns: Remove dqpn filling when modify qp from Init to Init
authorWenpeng Liang <liangwenpeng@huawei.com>
Thu, 26 Aug 2021 13:37:32 +0000 (21:37 +0800)
committerJason Gunthorpe <jgg@nvidia.com>
Thu, 26 Aug 2021 15:12:20 +0000 (12:12 -0300)
According to the IB specification, the destination qpn is allowed to be
filled into the qpc only when the qp transitions from Init to RTR, so this
code is unused.

Link: https://lore.kernel.org/r/1629985056-57004-4-git-send-email-liangwenpeng@huawei.com
Signed-off-by: Wenpeng Liang <liangwenpeng@huawei.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/hns/hns_roce_hw_v2.c

index 752bad5d5f8095620c6f3c5ae81a2f4ba51d5c07..85ad9379a69fac2cdc13784c40138e32aa74a59b 100644 (file)
@@ -4143,8 +4143,6 @@ static void modify_qp_init_to_init(struct ib_qp *ibqp,
                                   struct hns_roce_v2_qp_context *context,
                                   struct hns_roce_v2_qp_context *qpc_mask)
 {
-       struct hns_roce_qp *hr_qp = to_hr_qp(ibqp);
-
        /*
         * In v2 engine, software pass context and context mask to hardware
         * when modifying qp. If software need modify some fields in context,
@@ -4169,11 +4167,6 @@ static void modify_qp_init_to_init(struct ib_qp *ibqp,
                hr_reg_write(context, QPC_SRQN, to_hr_srq(ibqp->srq)->srqn);
                hr_reg_clear(qpc_mask, QPC_SRQN);
        }
-
-       if (attr_mask & IB_QP_DEST_QPN) {
-               hr_reg_write(context, QPC_DQPN, hr_qp->qpn);
-               hr_reg_clear(qpc_mask, QPC_DQPN);
-       }
 }
 
 static int config_qp_rq_buf(struct hns_roce_dev *hr_dev,