ath11k: update bawindow size in delba process

Currenly in delba process calling ath11k_peer_rx_tid_delete() updates
reo with desc invalid and add tid queue to the flush list. If station
send data traffic without addba req and before tid flush, hw gives
those packets as invalid desc reo error. Since we are dropping these
invalid desc packets results in traffic stall.

This patch fix this issue by updating the reo queue with bawindow size 1
instead of tid removal in delba process.

Signed-off-by: Venkateswara Naralasetty <vnaralas@codeaurora.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index f87bd327b082bbd32f5dda95b46656e8285bb230..8c21925a522a7b95af7b423c251d7bb087ffd7db 100644 (file)
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -641,7 +641,8 @@ void ath11k_peer_rx_tid_cleanup(struct ath11k *ar, struct ath11k_peer *peer)
 static int ath11k_peer_rx_tid_reo_update(struct ath11k *ar,
                                         struct ath11k_peer *peer,
                                         struct dp_rx_tid *rx_tid,
-                                        u32 ba_win_sz, u16 ssn)
+                                        u32 ba_win_sz, u16 ssn,
+                                        bool update_ssn)
 {
        struct ath11k_hal_reo_cmd cmd = {0};
        int ret;
@@ -649,10 +650,13 @@ static int ath11k_peer_rx_tid_reo_update(struct ath11k *ar,
        cmd.addr_lo = lower_32_bits(rx_tid->paddr);
        cmd.addr_hi = upper_32_bits(rx_tid->paddr);
        cmd.flag = HAL_REO_CMD_FLG_NEED_STATUS;
-       cmd.upd0 = HAL_REO_CMD_UPD0_BA_WINDOW_SIZE |
-                  HAL_REO_CMD_UPD0_SSN;
+       cmd.upd0 = HAL_REO_CMD_UPD0_BA_WINDOW_SIZE;
        cmd.ba_window_size = ba_win_sz;
-       cmd.upd2 = FIELD_PREP(HAL_REO_CMD_UPD2_SSN, ssn);
+
+       if (update_ssn) {
+               cmd.upd0 |= HAL_REO_CMD_UPD0_SSN;
+               cmd.upd2 = FIELD_PREP(HAL_REO_CMD_UPD2_SSN, ssn);
+       }
 
        ret = ath11k_dp_tx_send_reo_cmd(ar->ab, rx_tid,
                                        HAL_REO_CMD_UPDATE_RX_QUEUE, &cmd,
@@ -722,7 +726,7 @@ int ath11k_peer_rx_tid_setup(struct ath11k *ar, const u8 *peer_mac, int vdev_id,
        if (rx_tid->active) {
                paddr = rx_tid->paddr;
                ret = ath11k_peer_rx_tid_reo_update(ar, peer, rx_tid,
-                                                   ba_win_sz, ssn);
+                                                   ba_win_sz, ssn, true);
                spin_unlock_bh(&ab->base_lock);
                if (ret) {
                        ath11k_warn(ab, "failed to update reo for rx tid %d\n", tid);
@@ -832,12 +836,18 @@ int ath11k_dp_rx_ampdu_stop(struct ath11k *ar,
        paddr = peer->rx_tid[params->tid].paddr;
        active = peer->rx_tid[params->tid].active;
 
-       ath11k_peer_rx_tid_delete(ar, peer, params->tid);
+       if (!active) {
+               spin_unlock_bh(&ab->base_lock);
+               return 0;
+       }
 
+       ret = ath11k_peer_rx_tid_reo_update(ar, peer, peer->rx_tid, 1, 0, false);
        spin_unlock_bh(&ab->base_lock);
-
-       if (!active)
-               return 0;
+       if (ret) {
+               ath11k_warn(ab, "failed to update reo for rx tid %d: %d\n",
+                           params->tid, ret);
+               return ret;
+       }
 
        ret = ath11k_wmi_peer_rx_reorder_queue_setup(ar, vdev_id,
                                                     params->sta->addr, paddr,