vhost-scsi: Clarify vhost_virtqueue_mask argument
authorLu Lina <lina.lulina@huawei.com>
Mon, 27 Jul 2015 06:25:59 +0000 (14:25 +0800)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 14 Aug 2015 21:40:32 +0000 (23:40 +0200)
vhost_virtqueue_mask takes an "absolute" virtqueue index, while the
code looks like it's passing an index that is relative to
s->dev.vq_index.  In reality, s->dev.vq_index is always zero, so
this patch does not make any difference, but the code is clearer.

Signed-off-by: Lu Lina <lina.lulina@huawei.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Message-Id: <1437978359-17960-1-git-send-email-arei.gonglei@huawei.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/scsi/vhost-scsi.c

index 0dd57ff6b49f6cdd797d15845b2c37d1305d0bd3..7eacca9dc50bb2313ee842a61b5fd66d3010289c 100644 (file)
@@ -118,7 +118,7 @@ static int vhost_scsi_start(VHostSCSI *s)
      * enabling/disabling irqfd.
      */
     for (i = 0; i < s->dev.nvqs; i++) {
-        vhost_virtqueue_mask(&s->dev, vdev, i, false);
+        vhost_virtqueue_mask(&s->dev, vdev, s->dev.vq_index + i, false);
     }
 
     return ret;