extcon: qcom-spmi: Switch to platform_get_irq_byname_optional
authorBryan O'Donoghue <bryan.odonoghue@linaro.org>
Wed, 28 Dec 2022 13:30:58 +0000 (13:30 +0000)
committerChanwoo Choi <cw00.choi@samsung.com>
Mon, 29 May 2023 14:30:15 +0000 (23:30 +0900)
Valid configurations for the extcon interrupt declarations are

- usb_id
- usb_vbus
- (usb_id | usb_vbus)

In the case of a standalone usb_id or usb_vbus failure to find one of the
interrupts shouldn't generate a warning message. A warning is already in
place if both IRQs are missing.

Switch to using platform_get_irq_byname_optional() in order to facilitate
this behaviour.

Suggested-by: Marijn Suijten <marijn.suijten@somainline.org>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/extcon/extcon-qcom-spmi-misc.c

index eb02cb962b5e18585ef4be6266351314527a8493..f72e90ceca53d5909a5c01e0ade3f5005d2d2323 100644 (file)
@@ -123,7 +123,7 @@ static int qcom_usb_extcon_probe(struct platform_device *pdev)
        if (ret)
                return ret;
 
-       info->id_irq = platform_get_irq_byname(pdev, "usb_id");
+       info->id_irq = platform_get_irq_byname_optional(pdev, "usb_id");
        if (info->id_irq > 0) {
                ret = devm_request_threaded_irq(dev, info->id_irq, NULL,
                                        qcom_usb_irq_handler,
@@ -136,7 +136,7 @@ static int qcom_usb_extcon_probe(struct platform_device *pdev)
                }
        }
 
-       info->vbus_irq = platform_get_irq_byname(pdev, "usb_vbus");
+       info->vbus_irq = platform_get_irq_byname_optional(pdev, "usb_vbus");
        if (info->vbus_irq > 0) {
                ret = devm_request_threaded_irq(dev, info->vbus_irq, NULL,
                                        qcom_usb_irq_handler,