auxdisplay: linedisp: Move exported symbols to a namespace
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 12 Feb 2024 17:01:39 +0000 (19:01 +0200)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 15 Feb 2024 11:31:21 +0000 (13:31 +0200)
Avoid unnecessary pollution of the global symbol namespace by
moving library functions in to a specific namespace and import
that into the drivers that make use of the functions.

For more info: https://lwn.net/Articles/760045/

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/auxdisplay/ht16k33.c
drivers/auxdisplay/img-ascii-lcd.c
drivers/auxdisplay/line-display.c

index a90430b7d07ba438c40685ecc043cd0fdd745775..c6a42c5c128f055eedcaea312e4e45583a0379c3 100644 (file)
@@ -831,4 +831,5 @@ module_i2c_driver(ht16k33_driver);
 
 MODULE_DESCRIPTION("Holtek HT16K33 driver");
 MODULE_LICENSE("GPL");
+MODULE_IMPORT_NS(LINEDISP);
 MODULE_AUTHOR("Robin van der Gracht <robin@protonic.nl>");
index 09014ada38bda7d9b40ddaade19b0562d37bba04..c571e54d9eb569d48c9670c0fb3478bb971a7e9f 100644 (file)
@@ -298,3 +298,4 @@ module_platform_driver(img_ascii_lcd_driver);
 MODULE_DESCRIPTION("Imagination Technologies ASCII LCD Display");
 MODULE_AUTHOR("Paul Burton <paul.burton@mips.com>");
 MODULE_LICENSE("GPL");
+MODULE_IMPORT_NS(LINEDISP);
index a0339e4b5939befa709098d7a3bfeb73216e6f57..8d0ebdf0f10d4bf2696563949fb12d5a8a1a4c71 100644 (file)
@@ -263,7 +263,7 @@ out_del_timer:
        put_device(&linedisp->dev);
        return err;
 }
-EXPORT_SYMBOL_GPL(linedisp_register);
+EXPORT_SYMBOL_NS_GPL(linedisp_register, LINEDISP);
 
 /**
  * linedisp_unregister - unregister a character line display
@@ -276,6 +276,6 @@ void linedisp_unregister(struct linedisp *linedisp)
        del_timer_sync(&linedisp->timer);
        put_device(&linedisp->dev);
 }
-EXPORT_SYMBOL_GPL(linedisp_unregister);
+EXPORT_SYMBOL_NS_GPL(linedisp_unregister, LINEDISP);
 
 MODULE_LICENSE("GPL");