i2c: designware-pci: Use standard pattern for memory allocation
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 29 Sep 2022 09:42:15 +0000 (12:42 +0300)
committerWolfram Sang <wsa@kernel.org>
Sat, 1 Oct 2022 22:43:11 +0000 (00:43 +0200)
The pattern
foo = kmalloc(sizeof(*foo), GFP_KERNEL);
has an advantage when foo type is changed. Since we are planning a such,
better to be prepared by using standard pattern for memory allocation.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-designware-pcidrv.c

index 6e8a9d26563a2a923886d126d91971723fc61150..e499f96506c521ee1212ae87e2d5103e53b2f71e 100644 (file)
@@ -263,7 +263,7 @@ static int i2c_dw_pci_probe(struct pci_dev *pdev,
                return dev_err_probe(&pdev->dev, r,
                                     "I/O memory remapping failed\n");
 
-       dev = devm_kzalloc(&pdev->dev, sizeof(struct dw_i2c_dev), GFP_KERNEL);
+       dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
        if (!dev)
                return -ENOMEM;