loop: unset GENHD_FL_NO_PART_SCAN on LOOP_CONFIGURE
authorLennart Poettering <mzxreary@0pointer.de>
Mon, 10 Aug 2020 17:16:32 +0000 (19:16 +0200)
committerJens Axboe <axboe@kernel.dk>
Tue, 11 Aug 2020 13:13:06 +0000 (07:13 -0600)
When LOOP_CONFIGURE is used with LO_FLAGS_PARTSCAN we need to propagate
this into the GENHD_FL_NO_PART_SCAN. LOOP_SETSTATUS does this,
LOOP_CONFIGURE doesn't so far. Effect is that setting up a loopback
device with partition scanning doesn't actually work when LOOP_CONFIGURE
is issued, though it works fine with LOOP_SETSTATUS.

Let's correct that and propagate the flag in LOOP_CONFIGURE too.

Fixes: 3448914e8cc5("loop: Add LOOP_CONFIGURE ioctl")
Signed-off-by: Lennart Poettering <lennart@poettering.net>
Acked-by: Martijn Coenen <maco@android.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/loop.c

index d181601462260b3fb126149e011be4f96d882f95..2f137d6ce169d581a144870744d39a3faeafd089 100644 (file)
@@ -1171,6 +1171,8 @@ static int loop_configure(struct loop_device *lo, fmode_t mode,
        if (part_shift)
                lo->lo_flags |= LO_FLAGS_PARTSCAN;
        partscan = lo->lo_flags & LO_FLAGS_PARTSCAN;
+       if (partscan)
+               lo->lo_disk->flags &= ~GENHD_FL_NO_PART_SCAN;
 
        /* Grab the block_device to prevent its destruction after we
         * put /dev/loopXX inode. Later in __loop_clr_fd() we bdput(bdev).