tests/migration: Convert x86 boot block compilation script into Makefile
authorWei Huang <wei@redhat.com>
Wed, 5 Sep 2018 19:15:31 +0000 (15:15 -0400)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Wed, 26 Sep 2018 11:28:12 +0000 (12:28 +0100)
The x86 boot block header currently is generated with a shell script.
To better support other CPUs (e.g. aarch64), we convert the script
into Makefile. This allows us to 1) support cross-compilation easily,
and 2) avoid creating a script file for every architecture.

Note that, in the new design, the cross compiler prefix can be specified by
setting the CROSS_PREFIX in "make" command. Also to allow gcc pre-processor
to include the C-style file correctly, it also renames the
x86-a-b-bootblock.s file extension from .s to .S.

Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: Wei Huang <wei@redhat.com>
Message-Id: <1536174934-26022-2-git-send-email-wei@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
tests/migration/Makefile [new file with mode: 0644]
tests/migration/rebuild-x86-bootblock.sh [deleted file]
tests/migration/x86-a-b-bootblock.S [new file with mode: 0644]
tests/migration/x86-a-b-bootblock.s [deleted file]

diff --git a/tests/migration/Makefile b/tests/migration/Makefile
new file mode 100644 (file)
index 0000000..c0824b4
--- /dev/null
@@ -0,0 +1,31 @@
+# To specify cross compiler prefix, use CROSS_PREFIX=
+#   $ make CROSS_PREFIX=x86_64-linux-gnu-
+
+override define __note
+/* This file is automatically generated from
+ * tests/migration/x86-a-b-bootblock.S, edit that and then run
+ * tests/migration/rebuild-x86-bootblock.sh to update,
+ * and then remember to send both in your patch submission.
+ */
+endef
+export __note
+
+.PHONY: all clean
+all: x86-a-b-bootblock.h
+
+x86-a-b-bootblock.h: x86.bootsect
+       echo "$$__note" > header.tmp
+       xxd -i $< | sed -e 's/.*int.*//' >> header.tmp
+       mv header.tmp $@
+
+x86.bootsect: x86.boot
+       dd if=$< of=$@ bs=256 count=2 skip=124
+
+x86.boot: x86.o
+       $(CROSS_PREFIX)objcopy -O binary $< $@
+
+x86.o: x86-a-b-bootblock.S
+       $(CROSS_PREFIX)gcc -m32 -march=i486 -c $< -o $@
+
+clean:
+       @rm -rf *.boot *.o *.bootsect
diff --git a/tests/migration/rebuild-x86-bootblock.sh b/tests/migration/rebuild-x86-bootblock.sh
deleted file mode 100755 (executable)
index 86cec5d..0000000
+++ /dev/null
@@ -1,33 +0,0 @@
-#!/bin/sh
-# Copyright (c) 2016-2018 Red Hat, Inc. and/or its affiliates
-# This work is licensed under the terms of the GNU GPL, version 2 or later.
-# See the COPYING file in the top-level directory.
-#
-# Author: dgilbert@redhat.com
-
-ASMFILE=$PWD/tests/migration/x86-a-b-bootblock.s
-HEADER=$PWD/tests/migration/x86-a-b-bootblock.h
-
-if [ ! -e "$ASMFILE" ]
-then
-  echo "Couldn't find $ASMFILE" >&2
-  exit 1
-fi
-
-ASM_WORK_DIR=$(mktemp -d --tmpdir X86BB.XXXXXX)
-cd "$ASM_WORK_DIR" &&
-as --32 -march=i486 "$ASMFILE" -o x86.o &&
-objcopy -O binary x86.o x86.boot &&
-dd if=x86.boot of=x86.bootsect bs=256 count=2 skip=124 &&
-xxd -i x86.bootsect |
-sed -e 's/.*int.*//' > x86.hex &&
-cat - x86.hex <<HERE > "$HEADER"
-/* This file is automatically generated from
- * tests/migration/x86-a-b-bootblock.s, edit that and then run
- * tests/migration/rebuild-x86-bootblock.sh to update,
- * and then remember to send both in your patch submission.
- */
-HERE
-
-rm x86.hex x86.bootsect x86.boot x86.o
-cd .. && rmdir "$ASM_WORK_DIR"
diff --git a/tests/migration/x86-a-b-bootblock.S b/tests/migration/x86-a-b-bootblock.S
new file mode 100644 (file)
index 0000000..b164264
--- /dev/null
@@ -0,0 +1,92 @@
+# x86 bootblock used in migration test
+#  repeatedly increments the first byte of each page in a 100MB
+#  range.
+#  Outputs an initial 'A' on serial followed by repeated 'B's
+#
+# run   tests/migration/rebuild-x86-bootblock.sh
+#   to regenerate the hex, and remember to include both the .h and .s
+#   in any patches.
+#
+# Copyright (c) 2016 Red Hat, Inc. and/or its affiliates
+# This work is licensed under the terms of the GNU GPL, version 2 or later.
+# See the COPYING file in the top-level directory.
+#
+# Author: dgilbert@redhat.com
+
+
+.code16
+.org 0x7c00
+        .file   "fill.s"
+        .text
+        .globl  start
+        .type   start, @function
+start:             # at 0x7c00 ?
+        cli
+        lgdt gdtdesc
+        mov $1,%eax
+        mov %eax,%cr0  # Protected mode enable
+        data32 ljmp $8,$0x7c20
+
+.org 0x7c20
+.code32
+        # A20 enable - not sure I actually need this
+        inb $0x92,%al
+        or  $2,%al
+        outb %al, $0x92
+
+        # set up DS for the whole of RAM (needed on KVM)
+        mov $16,%eax
+        mov %eax,%ds
+
+        mov $65,%ax
+        mov $0x3f8,%dx
+        outb %al,%dx
+
+        # bl keeps a counter so we limit the output speed
+        mov $0, %bl
+mainloop:
+        # Start from 1MB
+        mov $(1024*1024),%eax
+innerloop:
+        incb (%eax)
+        add $4096,%eax
+        cmp $(100*1024*1024),%eax
+        jl innerloop
+
+        inc %bl
+        jnz mainloop
+
+        mov $66,%ax
+        mov $0x3f8,%dx
+        outb %al,%dx
+
+        jmp mainloop
+
+        # GDT magic from old (GPLv2)  Grub startup.S
+        .p2align        2       /* force 4-byte alignment */
+gdt:
+        .word   0, 0
+        .byte   0, 0, 0, 0
+
+        /* -- code segment --
+         * base = 0x00000000, limit = 0xFFFFF (4 KiB Granularity), present
+         * type = 32bit code execute/read, DPL = 0
+         */
+        .word   0xFFFF, 0
+        .byte   0, 0x9A, 0xCF, 0
+
+        /* -- data segment --
+         * base = 0x00000000, limit 0xFFFFF (4 KiB Granularity), present
+         * type = 32 bit data read/write, DPL = 0
+         */
+        .word   0xFFFF, 0
+        .byte   0, 0x92, 0xCF, 0
+
+gdtdesc:
+        .word   0x27                    /* limit */
+        .long   gdt                     /* addr */
+
+/* I'm a bootable disk */
+.org 0x7dfe
+        .byte 0x55
+        .byte 0xAA
diff --git a/tests/migration/x86-a-b-bootblock.s b/tests/migration/x86-a-b-bootblock.s
deleted file mode 100644 (file)
index b164264..0000000
+++ /dev/null
@@ -1,92 +0,0 @@
-# x86 bootblock used in migration test
-#  repeatedly increments the first byte of each page in a 100MB
-#  range.
-#  Outputs an initial 'A' on serial followed by repeated 'B's
-#
-# run   tests/migration/rebuild-x86-bootblock.sh
-#   to regenerate the hex, and remember to include both the .h and .s
-#   in any patches.
-#
-# Copyright (c) 2016 Red Hat, Inc. and/or its affiliates
-# This work is licensed under the terms of the GNU GPL, version 2 or later.
-# See the COPYING file in the top-level directory.
-#
-# Author: dgilbert@redhat.com
-
-
-.code16
-.org 0x7c00
-        .file   "fill.s"
-        .text
-        .globl  start
-        .type   start, @function
-start:             # at 0x7c00 ?
-        cli
-        lgdt gdtdesc
-        mov $1,%eax
-        mov %eax,%cr0  # Protected mode enable
-        data32 ljmp $8,$0x7c20
-
-.org 0x7c20
-.code32
-        # A20 enable - not sure I actually need this
-        inb $0x92,%al
-        or  $2,%al
-        outb %al, $0x92
-
-        # set up DS for the whole of RAM (needed on KVM)
-        mov $16,%eax
-        mov %eax,%ds
-
-        mov $65,%ax
-        mov $0x3f8,%dx
-        outb %al,%dx
-
-        # bl keeps a counter so we limit the output speed
-        mov $0, %bl
-mainloop:
-        # Start from 1MB
-        mov $(1024*1024),%eax
-innerloop:
-        incb (%eax)
-        add $4096,%eax
-        cmp $(100*1024*1024),%eax
-        jl innerloop
-
-        inc %bl
-        jnz mainloop
-
-        mov $66,%ax
-        mov $0x3f8,%dx
-        outb %al,%dx
-
-        jmp mainloop
-
-        # GDT magic from old (GPLv2)  Grub startup.S
-        .p2align        2       /* force 4-byte alignment */
-gdt:
-        .word   0, 0
-        .byte   0, 0, 0, 0
-
-        /* -- code segment --
-         * base = 0x00000000, limit = 0xFFFFF (4 KiB Granularity), present
-         * type = 32bit code execute/read, DPL = 0
-         */
-        .word   0xFFFF, 0
-        .byte   0, 0x9A, 0xCF, 0
-
-        /* -- data segment --
-         * base = 0x00000000, limit 0xFFFFF (4 KiB Granularity), present
-         * type = 32 bit data read/write, DPL = 0
-         */
-        .word   0xFFFF, 0
-        .byte   0, 0x92, 0xCF, 0
-
-gdtdesc:
-        .word   0x27                    /* limit */
-        .long   gdt                     /* addr */
-
-/* I'm a bootable disk */
-.org 0x7dfe
-        .byte 0x55
-        .byte 0xAA