ALSA: ump: Don't clear bank selection after sending a program change

The current code clears the bank selection MSB/LSB after sending a
program change, but this can be wrong, as many apps may not send the
full bank selection with both MSB and LSB but sending only one.
Better to keep the previous bank set.

Fixes: 0b5288f5fe63 ("ALSA: ump: Add legacy raw MIDI support")
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20240529083823.5778-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/core/ump_convert.c b/sound/core/ump_convert.c
index de04799fdb69aaf3b08de639739e52f09ebb55a3..f67c44c83fde445258c59f34897b73a913c17cf1 100644 (file)
--- a/sound/core/ump_convert.c
+++ b/sound/core/ump_convert.c
@@ -404,7 +404,6 @@ static int cvt_legacy_cmd_to_ump(struct ump_cvt_to_ump *cvt,
                        midi2->pg.bank_msb = cc->cc_bank_msb;
                        midi2->pg.bank_lsb = cc->cc_bank_lsb;
                        cc->bank_set = 0;
-                       cc->cc_bank_msb = cc->cc_bank_lsb = 0;
                }
                break;
        case UMP_MSG_STATUS_CHANNEL_PRESSURE: