selftests: firmware: Fix ignored return val of asprintf() warn
authorShuah Khan <skhan@linuxfoundation.org>
Thu, 8 Jul 2021 03:18:27 +0000 (21:18 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 21 Jul 2021 14:11:42 +0000 (16:11 +0200)
Fix the following ingonred return val of asprintf() warn during
build:

cc -Wall -O2    fw_namespace.c  -o ../tools/testing/selftests/firmware/fw_namespace
fw_namespace.c: In function ‘main’:
fw_namespace.c:132:2: warning: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  132 |  asprintf(&fw_path, "/lib/firmware/%s", fw_name);
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Link: https://lore.kernel.org/r/20210708031827.51293-1-skhan@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/testing/selftests/firmware/fw_namespace.c

index 0e393cb5f42de42d9d93a4b954b32b16881bb7e6..4c6f0cd83c5b0f1c24360188952ba97103334a3c 100644 (file)
@@ -129,7 +129,8 @@ int main(int argc, char **argv)
                die("mounting tmpfs to /lib/firmware failed\n");
 
        sys_path = argv[1];
-       asprintf(&fw_path, "/lib/firmware/%s", fw_name);
+       if (asprintf(&fw_path, "/lib/firmware/%s", fw_name) < 0)
+               die("error: failed to build full fw_path\n");
 
        setup_fw(fw_path);