ASoC: Intel: avs: Init debugfs before booting firmware
authorCezary Rojewski <cezary.rojewski@intel.com>
Fri, 5 Apr 2024 09:09:27 +0000 (11:09 +0200)
committerMark Brown <broonie@kernel.org>
Fri, 5 Apr 2024 12:13:11 +0000 (13:13 +0100)
When bringing up setups it's vital to have access to debug functionality
even if firmware boot fails. As order of probe()ing operations is
changed, update remove() procedure accordingly.

Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://msgid.link/r/20240405090929.1184068-12-cezary.rojewski@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/avs/core.c

index d7f8940099cec6510c1179b7045134243767625d..76782a0f32bc3ea106fbe656b8e8e5fe7177ce8f 100644 (file)
@@ -209,6 +209,7 @@ static void avs_hda_probe_work(struct work_struct *work)
 
        snd_hdac_ext_bus_ppcap_enable(bus, true);
        snd_hdac_ext_bus_ppcap_int_enable(bus, true);
+       avs_debugfs_init(adev);
 
        ret = avs_dsp_first_boot_firmware(adev);
        if (ret < 0)
@@ -217,7 +218,6 @@ static void avs_hda_probe_work(struct work_struct *work)
        adev->nhlt = intel_nhlt_init(adev->dev);
        if (!adev->nhlt)
                dev_info(bus->dev, "platform has no NHLT\n");
-       avs_debugfs_init(adev);
 
        avs_register_all_boards(adev);
 
@@ -548,9 +548,9 @@ static void avs_pci_remove(struct pci_dev *pci)
 
        avs_unregister_all_boards(adev);
 
-       avs_debugfs_exit(adev);
        if (adev->nhlt)
                intel_nhlt_free(adev->nhlt);
+       avs_debugfs_exit(adev);
 
        if (avs_platattr_test(adev, CLDMA))
                hda_cldma_free(&code_loader);