ARM: dts: rockchip: rename label and nodename pinctrl subnodes that end with gpio

A test with the command below gives for example this error:

arch/arm/boot/dts/rk3288-tinker.dt.yaml: tsadc: otp-gpio:
{'phandle': [[54]], 'rockchip,pins': [[0, 10, 0, 118]]}
is not of type 'array'

'gpio' is a sort of reserved nodename and should not be used
for pinctrl in combination with 'rockchip,pins', so change
nodes that end with 'gpio' to end with 'pin' or 'pins'.

make ARCH=arm dtbs_check
DT_SCHEMA_FILES=~/.local/lib/python3.5/site-packages/
dtschema/schemas/gpio/gpio.yaml

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Link: https://lore.kernel.org/r/20200524160636.16547-1-jbx6244@gmail.com
Signed-off-by: Heiko Stuebner <heiko@sntech.de>

diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
index b0fd92befdeb2a57e7530fadd14258536b51f218..3236abb0aba9e84c037b167dc9740de2722d0308 100644 (file)
--- a/arch/arm/boot/dts/rk322x.dtsi
+++ b/arch/arm/boot/dts/rk322x.dtsi
@@ -520,9 +520,9 @@
                resets = <&cru SRST_TSADC>;
                reset-names = "tsadc-apb";
                pinctrl-names = "init", "default", "sleep";
-               pinctrl-0 = <&otp_gpio>;
+               pinctrl-0 = <&otp_pin>;
                pinctrl-1 = <&otp_out>;
-               pinctrl-2 = <&otp_gpio>;
+               pinctrl-2 = <&otp_pin>;
                #thermal-sensor-cells = <0>;
                rockchip,hw-tshut-temp = <95000>;
                status = "disabled";
@@ -1111,7 +1111,7 @@
                };
 
                tsadc {
-                       otp_gpio: otp-gpio {
+                       otp_pin: otp-pin {
                                rockchip,pins = <0 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>;
                        };
 

diff --git a/arch/arm/boot/dts/rk3288-veyron-jaq.dts b/arch/arm/boot/dts/rk3288-veyron-jaq.dts
index 171ba6185b6d391d50591039e6b73221e14e5c1a..8efba9deae3c7724168a9ec855c13166ec5fa3b9 100644 (file)
--- a/arch/arm/boot/dts/rk3288-veyron-jaq.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-jaq.dts
@@ -47,7 +47,7 @@
 &sdmmc {
        disable-wp;
        pinctrl-names = "default";
-       pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd_disabled &sdmmc_cd_gpio
+       pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd_disabled &sdmmc_cd_pin
                        &sdmmc_bus4>;
 };
 

diff --git a/arch/arm/boot/dts/rk3288-veyron-jerry.dts b/arch/arm/boot/dts/rk3288-veyron-jerry.dts
index 66f00d28801a139de232e49349cbfffbbeb1b44d..2c916c50dda5092471c1a2252a98da6183ca8be7 100644 (file)
--- a/arch/arm/boot/dts/rk3288-veyron-jerry.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-jerry.dts
@@ -192,7 +192,7 @@
 &sdmmc {
        disable-wp;
        pinctrl-names = "default";
-       pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd_disabled &sdmmc_cd_gpio
+       pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd_disabled &sdmmc_cd_pin
                        &sdmmc_bus4>;
 };
 

diff --git a/arch/arm/boot/dts/rk3288-veyron-mighty.dts b/arch/arm/boot/dts/rk3288-veyron-mighty.dts
index 27fbc07476d20af6da333411193aa4ff3ac134e3..fa695a88f2368f946b9d348996775e0391bc1350 100644 (file)
--- a/arch/arm/boot/dts/rk3288-veyron-mighty.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-mighty.dts
@@ -18,8 +18,8 @@
 };
 
 &sdmmc {
-       pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd_disabled &sdmmc_cd_gpio
-                       &sdmmc_wp_gpio &sdmmc_bus4>;
+       pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd_disabled &sdmmc_cd_pin
+                       &sdmmc_wp_pin &sdmmc_bus4>;
        wp-gpios = <&gpio7 10 GPIO_ACTIVE_HIGH>;
 
        /delete-property/ disable-wp;
@@ -27,7 +27,7 @@
 
 &pinctrl {
        sdmmc {
-               sdmmc_wp_gpio: sdmmc-wp-gpio {
+               sdmmc_wp_pin: sdmmc-wp-pin {
                        rockchip,pins = <7 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>;
                };
        };

diff --git a/arch/arm/boot/dts/rk3288-veyron-minnie.dts b/arch/arm/boot/dts/rk3288-veyron-minnie.dts
index 383fad1a88a1022cc75e68399c686252d79653dd..f8b69e0a16a02dbf4b0abfbf939f324263d6a5a2 100644 (file)
--- a/arch/arm/boot/dts/rk3288-veyron-minnie.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-minnie.dts
@@ -114,7 +114,7 @@
 &sdmmc {
        disable-wp;
        pinctrl-names = "default";
-       pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd_disabled &sdmmc_cd_gpio
+       pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd_disabled &sdmmc_cd_pin
                        &sdmmc_bus4>;
 };
 

diff --git a/arch/arm/boot/dts/rk3288-veyron-pinky.dts b/arch/arm/boot/dts/rk3288-veyron-pinky.dts
index 71e6629cc2089304739eaac20dd13ddffb2b1d4c..4e9fdb0f722d89a8679072a3e7292ee2e9b2f6f6 100644 (file)
--- a/arch/arm/boot/dts/rk3288-veyron-pinky.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-pinky.dts
@@ -105,7 +105,7 @@
        };
 
        sdmmc {
-               sdmmc_wp_gpio: sdmmc-wp-gpio {
+               sdmmc_wp_pin: sdmmc-wp-pin {
                        rockchip,pins = <7 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>;
                };
        };
@@ -126,8 +126,8 @@
 
 &sdmmc {
        pinctrl-names = "default";
-       pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd_disabled &sdmmc_cd_gpio
-                    &sdmmc_wp_gpio &sdmmc_bus4>;
+       pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd_disabled &sdmmc_cd_pin
+                    &sdmmc_wp_pin &sdmmc_bus4>;
        wp-gpios = <&gpio7 RK_PB2 GPIO_ACTIVE_HIGH>;
 };
 

diff --git a/arch/arm/boot/dts/rk3288-veyron-sdmmc.dtsi b/arch/arm/boot/dts/rk3288-veyron-sdmmc.dtsi
index fe950f9863e8743e72e21805b8eb07f523c5fd92..27fb06ce907e87db4a5e40114a1959fbbf8943df 100644 (file)
--- a/arch/arm/boot/dts/rk3288-veyron-sdmmc.dtsi
+++ b/arch/arm/boot/dts/rk3288-veyron-sdmmc.dtsi
@@ -41,7 +41,7 @@
                };
 
                /* This is where we actually hook up CD */
-               sdmmc_cd_gpio: sdmmc-cd-gpio {
+               sdmmc_cd_pin: sdmmc-cd-pin {
                        rockchip,pins = <7 RK_PA5 RK_FUNC_GPIO &pcfg_pull_none>;
                };
        };

diff --git a/arch/arm/boot/dts/rk3288-veyron-speedy.dts b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
index e354c61a45e7e8c5e174c7817abc940571c5b2ff..4a3ea934d03e5de7bf3071038b5165ad15b9613a 100644 (file)
--- a/arch/arm/boot/dts/rk3288-veyron-speedy.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
@@ -54,7 +54,7 @@
 &sdmmc {
        disable-wp;
        pinctrl-names = "default";
-       pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd_disabled &sdmmc_cd_gpio
+       pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd_disabled &sdmmc_cd_pin
                        &sdmmc_bus4>;
 };
 

diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 2e1edd85f04a6f6c3f28569e3db230b49d7a2b0d..84d59469035ee0ed6fb93358a16d2dd6e21f1b4f 100644 (file)
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -574,9 +574,9 @@
                resets = <&cru SRST_TSADC>;
                reset-names = "tsadc-apb";
                pinctrl-names = "init", "default", "sleep";
-               pinctrl-0 = <&otp_gpio>;
+               pinctrl-0 = <&otp_pin>;
                pinctrl-1 = <&otp_out>;
-               pinctrl-2 = <&otp_gpio>;
+               pinctrl-2 = <&otp_pin>;
                #thermal-sensor-cells = <1>;
                rockchip,grf = <&grf>;
                rockchip,hw-tshut-temp = <95000>;
@@ -1929,7 +1929,7 @@
                };
 
                tsadc {
-                       otp_gpio: otp-gpio {
+                       otp_pin: otp-pin {
                                rockchip,pins = <0 RK_PB2 RK_FUNC_GPIO &pcfg_pull_none>;
                        };
 

diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
index f9cfe2c807916670bef8055373b46293efcbf260..a5d130bd05474d3220f011fdc56cdce1cf2b78c8 100644 (file)
--- a/arch/arm/boot/dts/rv1108.dtsi
+++ b/arch/arm/boot/dts/rv1108.dtsi
@@ -351,9 +351,9 @@
                clocks = <&cru SCLK_TSADC>, <&cru PCLK_TSADC>;
                clock-names = "tsadc", "apb_pclk";
                pinctrl-names = "init", "default", "sleep";
-               pinctrl-0 = <&otp_gpio>;
+               pinctrl-0 = <&otp_pin>;
                pinctrl-1 = <&otp_out>;
-               pinctrl-2 = <&otp_gpio>;
+               pinctrl-2 = <&otp_pin>;
                resets = <&cru SRST_TSADC>;
                reset-names = "tsadc-apb";
                rockchip,hw-tshut-temp = <120000>;
@@ -728,7 +728,7 @@
                                                <0 RK_PC6 3 &pcfg_pull_none>;
                        };
 
-                       i2c2m1_gpio: i2c2m1-gpio {
+                       i2c2m1_pins: i2c2m1-pins {
                                rockchip,pins = <0 RK_PC2 RK_FUNC_GPIO &pcfg_pull_none>,
                                                <0 RK_PC6 RK_FUNC_GPIO &pcfg_pull_none>;
                        };
@@ -740,7 +740,7 @@
                                                <1 RK_PD4 2 &pcfg_pull_none>;
                        };
 
-                       i2c2m05v_gpio: i2c2m05v-gpio {
+                       i2c2m05v_pins: i2c2m05v-pins {
                                rockchip,pins = <1 RK_PD5 RK_FUNC_GPIO &pcfg_pull_none>,
                                                <1 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>;
                        };
@@ -867,7 +867,7 @@
                                rockchip,pins = <0 RK_PB7 1 &pcfg_pull_none>;
                        };
 
-                       otp_gpio: otp-gpio {
+                       otp_pin: otp-pin {
                                rockchip,pins = <0 RK_PB7 RK_FUNC_GPIO &pcfg_pull_none>;
                        };
                };
@@ -886,7 +886,7 @@
                                rockchip,pins = <3 RK_PA3 1 &pcfg_pull_none>;
                        };
 
-                       uart0_rts_gpio: uart0-rts-gpio {
+                       uart0_rts_pin: uart0-rts-pin {
                                rockchip,pins = <3 RK_PA3 RK_FUNC_GPIO &pcfg_pull_none>;
                        };
                };