gfs2: Delay withdraw from atomic context
authorBob Peterson <rpeterso@redhat.com>
Fri, 30 Jul 2021 18:23:49 +0000 (13:23 -0500)
committerBob Peterson <rpeterso@redhat.com>
Fri, 20 Aug 2021 14:03:46 +0000 (09:03 -0500)
Before this patch, if function __gfs2_ail_flush detected an error
syncing the ail list, it call gfs2_ail_error which called gfs2_withdraw.
Since __gfs2_ail_flush deals with a specific glock, we shouldn't withdraw
immediately because the withdraw code (signal_our_withdraw) uses glocks
in its processing.

This patch changes the call from gfs2_withdraw to gfs2_withdraw_delayed
which defers the withdraw until a more appropriate context, such as the
logd daemon, discovers the intent to withdraw.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
fs/gfs2/glops.c

index 5fbdc7e9f4ff2a947167aab032ca430749e3bad7..79c621c7863d288bf0c9ea9d0e1953a50716ad5b 100644 (file)
@@ -44,7 +44,7 @@ static void gfs2_ail_error(struct gfs2_glock *gl, const struct buffer_head *bh)
               gl->gl_name.ln_type, gl->gl_name.ln_number,
               gfs2_glock2aspace(gl));
        gfs2_lm(sdp, "AIL error\n");
-       gfs2_withdraw(sdp);
+       gfs2_withdraw_delayed(sdp);
 }
 
 /**