From: Vas Sudanagunta <vas@commonkarma.org>
Date: Sun, 25 Feb 2018 06:15:03 +0000 (-0500)
Subject: Fix bug in Site.assembleSections method
X-Git-Tag: v0.37~8
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=00868081f624928d773a7b698654766f8cd70069;p=brevno-suite%2Fhugo

Fix bug in Site.assembleSections method

Site.assembleSections logic assumes that the the home page would always be the first in the Site's list of pages. This is not in fact guaranteed to be true. When it is not, the method can fail to set the parent for some or all root-level pages. 

Fixes #4447
---

diff --git a/hugolib/site_sections.go b/hugolib/site_sections.go
index 1a42f780..5de350b2 100644
--- a/hugolib/site_sections.go
+++ b/hugolib/site_sections.go
@@ -167,11 +167,15 @@ func (s *Site) assembleSections() Pages {
 		undecided  Pages
 	)
 
+	homes := s.findPagesByKind(KindHome)
+	if len(homes) == 1 {
+		home = homes[0]
+	} else if len(homes) > 1 {
+		panic("Too many homes")
+	}
+
 	for i, p := range s.Pages {
 		if p.Kind != KindPage {
-			if p.Kind == KindHome {
-				home = p
-			}
 			continue
 		}