From: Miaohe Lin Date: Fri, 29 Apr 2022 06:16:17 +0000 (-0700) Subject: mm: compaction: remove unneeded assignment to isolate_start_pfn X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=00bc102f82e0a0c70f1d4c9fdeb4c0cbc622d777;p=linux.git mm: compaction: remove unneeded assignment to isolate_start_pfn isolate_start_pfn is unused when cc->nr_freepages ! = 0. Otherwise cc->free_pfn will overwrite it unconditionally. So we should remove this unneeded and somewhat misleading assignment. Link: https://lkml.kernel.org/r/20220418141253.24298-4-linmiaohe@huawei.com Signed-off-by: Miaohe Lin Cc: Charan Teja Kalla Cc: David Hildenbrand Cc: Pintu Kumar Cc: Vlastimil Babka Signed-off-by: Andrew Morton --- diff --git a/mm/compaction.c b/mm/compaction.c index f9e628a5306a2..ee2ddf77191f5 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1586,7 +1586,7 @@ static void isolate_freepages(struct compact_control *cc) unsigned int stride; /* Try a small search of the free lists for a candidate */ - isolate_start_pfn = fast_isolate_freepages(cc); + fast_isolate_freepages(cc); if (cc->nr_freepages) goto splitmap;