From: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Date: Sat, 25 May 2019 09:15:59 +0000 (+0530)
Subject: ceph: fix warning PTR_ERR_OR_ZERO can be used
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=03af439ad9408c28e53b880daa56590dda1c8472;p=linux.git

ceph: fix warning PTR_ERR_OR_ZERO can be used

change1: fix below warning  reported by coccicheck

/fs/ceph/export.c:371:33-39: WARNING: PTR_ERR_OR_ZERO can be used

change2: typecasted PTR_ERR_OR_ZERO to long as dout expecting long

Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
---

diff --git a/fs/ceph/export.c b/fs/ceph/export.c
index d3ef7ee429ec0..15ff1b09cfa29 100644
--- a/fs/ceph/export.c
+++ b/fs/ceph/export.c
@@ -368,7 +368,7 @@ static struct dentry *ceph_get_parent(struct dentry *child)
 	}
 out:
 	dout("get_parent %p ino %llx.%llx err=%ld\n",
-	     child, ceph_vinop(inode), (IS_ERR(dn) ? PTR_ERR(dn) : 0));
+	     child, ceph_vinop(inode), (long)PTR_ERR_OR_ZERO(dn));
 	return dn;
 }