From: Michael Ellerman Date: Mon, 9 Oct 2017 10:52:44 +0000 (+1100) Subject: powerpc/perf/hv-24x7: Fix incorrect comparison in memord X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=05c14c03138532a3cb2aa29c2960445c8753343b;p=linux.git powerpc/perf/hv-24x7: Fix incorrect comparison in memord In the hv-24x7 code there is a function memord() which tries to implement a sort function return -1, 0, 1. However one of the conditions is incorrect, such that it can never be true, because we will have already returned. I don't believe there is a bug in practice though, because the comparisons are an optimisation prior to calling memcmp(). Fix it by swapping the second comparision, so it can be true. Reported-by: David Binderman Signed-off-by: Michael Ellerman --- diff --git a/arch/powerpc/perf/hv-24x7.c b/arch/powerpc/perf/hv-24x7.c index 9c88b82f62293..72238eedc360f 100644 --- a/arch/powerpc/perf/hv-24x7.c +++ b/arch/powerpc/perf/hv-24x7.c @@ -540,7 +540,7 @@ static int memord(const void *d1, size_t s1, const void *d2, size_t s2) { if (s1 < s2) return 1; - if (s2 > s1) + if (s1 > s2) return -1; return memcmp(d1, d2, s1);