From: Qinglang Miao Date: Mon, 21 Sep 2020 13:10:46 +0000 (+0800) Subject: net: qlcnic: simplify the return expression of qlcnic_83xx_shutdown X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=05c3b6e79db2910cdf9b80755204e96be3a83dcc;p=linux.git net: qlcnic: simplify the return expression of qlcnic_83xx_shutdown Simplify the return expression. Signed-off-by: Qinglang Miao Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c index fc490881cd03e..1753736c56f7b 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c @@ -3812,7 +3812,6 @@ static int qlcnic_83xx_shutdown(struct pci_dev *pdev) { struct qlcnic_adapter *adapter = pci_get_drvdata(pdev); struct net_device *netdev = adapter->netdev; - int retval; netif_device_detach(netdev); qlcnic_cancel_idc_work(adapter); @@ -3823,11 +3822,7 @@ static int qlcnic_83xx_shutdown(struct pci_dev *pdev) qlcnic_83xx_disable_mbx_intr(adapter); cancel_delayed_work_sync(&adapter->idc_aen_work); - retval = pci_save_state(pdev); - if (retval) - return retval; - - return 0; + return pci_save_state(pdev); } static int qlcnic_83xx_resume(struct qlcnic_adapter *adapter)