From: Yu Kuai Date: Wed, 2 Nov 2022 02:25:38 +0000 (+0800) Subject: block, bfq: remove set but not used variable in __bfq_entity_update_weight_prio X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=060d9217d356a28e1bcfd2df0c8bf59aa24a12ce;p=linux.git block, bfq: remove set but not used variable in __bfq_entity_update_weight_prio After the patch "block, bfq: cleanup bfq_weights_tree add/remove apis"), the local variable 'bfqd' is not used anymore, thus remove it. Signed-off-by: Yu Kuai Link: https://lore.kernel.org/r/20221102022542.3621219-2-yukuai1@huaweicloud.com Fixes: afdba1461262 ("block, bfq: cleanup bfq_weights_tree add/remove apis") Signed-off-by: Jens Axboe --- diff --git a/block/bfq-wf2q.c b/block/bfq-wf2q.c index 5a02cb94d86e9..2faa29fcb1e93 100644 --- a/block/bfq-wf2q.c +++ b/block/bfq-wf2q.c @@ -706,21 +706,6 @@ __bfq_entity_update_weight_prio(struct bfq_service_tree *old_st, if (entity->prio_changed) { struct bfq_queue *bfqq = bfq_entity_to_bfqq(entity); unsigned int prev_weight, new_weight; - struct bfq_data *bfqd = NULL; -#ifdef CONFIG_BFQ_GROUP_IOSCHED - struct bfq_sched_data *sd; - struct bfq_group *bfqg; -#endif - - if (bfqq) - bfqd = bfqq->bfqd; -#ifdef CONFIG_BFQ_GROUP_IOSCHED - else { - sd = entity->my_sched_data; - bfqg = container_of(sd, struct bfq_group, sched_data); - bfqd = (struct bfq_data *)bfqg->bfqd; - } -#endif /* Matches the smp_wmb() in bfq_group_set_weight. */ smp_rmb();