From: Sergio Paracuellos Date: Mon, 23 Apr 2018 13:44:47 +0000 (+0200) Subject: staging: ks7010: assign dev_alloc_name() result to variable before check it X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=06176b874a2e25343ffe4ed83c3c4d6290e97cf0;p=linux.git staging: ks7010: assign dev_alloc_name() result to variable before check it This commit assigns dev_alloc_name() call to 'ret' variable to check it after instead of check directly the call in the if condition. This improves a bit readability. It also add an empty line before the new assignment to separate it from the previous check statement block. Signed-off-by: Sergio Paracuellos Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c index 130e0be284db6..b29f48c421cca 100644 --- a/drivers/staging/ks7010/ks7010_sdio.c +++ b/drivers/staging/ks7010/ks7010_sdio.c @@ -1021,7 +1021,9 @@ static int ks7010_sdio_probe(struct sdio_func *func, dev_err(&card->func->dev, "Unable to alloc new net device\n"); goto err_release_irq; } - if (dev_alloc_name(netdev, "wlan%d") < 0) { + + ret = dev_alloc_name(netdev, "wlan%d"); + if (ret < 0) { dev_err(&card->func->dev, "Couldn't get name!\n"); goto err_free_netdev; }